Not logged in

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Properly escape the entirety of the Resources URLs in the infoview
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1:7a468e8d7a5a4873254947debd0ca7fcc51d893d
User & Date: brandon 2018-11-13 21:34:39
Context
2018-11-13
21:54
Do not try to render resources that end up with no description check-in: b248e65e10 user: brandon tags: trunk
21:34
Properly escape the entirety of the Resources URLs in the infoview check-in: 7a468e8d7a user: brandon tags: trunk
2018-11-11
23:39
Set the same sort function for all columns check-in: 72ccdaea06 user: brandon tags: trunk
Changes

Changes to src/grotesque/ui/gtk3/info/infoview.py.

330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
        text_buffer.insert(text_iter, "Resources:\n")
        for resource in resources:
            resource_anchor = text_buffer.create_child_anchor(text_iter)
            resource_label = Gtk.Label()
            resource_label.set_track_visited_links(False)
            resource_label.set_markup(
                '\t<a href="{0}">{1}</a>'.format(cgi.escape(resource["uri"]),
                                               resource["description"]))
            resource_label.connect("activate-link", self._on_resource_clicked)
            self.info_view.add_child_at_anchor(resource_label, resource_anchor)
            resource_label.show()
            text_buffer.insert(text_iter, "\n")

    def render_story(self, story_id):
        '''This method inserts the story information in the text buffer and







|







330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
        text_buffer.insert(text_iter, "Resources:\n")
        for resource in resources:
            resource_anchor = text_buffer.create_child_anchor(text_iter)
            resource_label = Gtk.Label()
            resource_label.set_track_visited_links(False)
            resource_label.set_markup(
                '\t<a href="{0}">{1}</a>'.format(cgi.escape(resource["uri"]),
                                                 cgi.escape(resource["description"])))
            resource_label.connect("activate-link", self._on_resource_clicked)
            self.info_view.add_child_at_anchor(resource_label, resource_anchor)
            resource_label.show()
            text_buffer.insert(text_iter, "\n")

    def render_story(self, story_id):
        '''This method inserts the story information in the text buffer and